Repository navigation
fix(reader): a float or decimal operand on an integer column fails instead of truncating - #702
Merged
Merged
Conversation
…stead of truncating
Compare's integer branch and PrimitiveFilter.lowerLong (the fused
kernels' long domain) read the operand with Number.longValue(), so a
Double, Float or BigDecimal was truncated: `x >= 1.5` on an I64 column
matched `x = 1`. Both now go through Compare.integer, which accepts an
integer of any width and throws VortexException otherwise, as Rust's
compare refuses operands of different dtypes ("Cannot compare different
DTypes i64 and f64", pinned against vortex-jni).
SQL was never affected: Calcite does not push a fractional literal onto
an integer column (FractionalLiteralTest pins every operator). A whole
double such as 2^53 is now refused too, which reverses the #159 test
that accepted it; the dtype differs, as in Rust.
Closes #701
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dfa1
force-pushed
the
fix/701-fractional-operand
branch
from
November 8, 2026 08:05
7855cd9 to
6a5e5a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #701.
🤖 Generated with Claude Code